[
https://issues.apache.org/jira/browse/HDDS-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795345#comment-16795345
]
Arpit Agarwal commented on HDDS-1205:
-------------------------------------
Thanks for the patch Nanda. One early comment:
# We should not make a copy of the containerID map in
SCMContainerManager#getContainerIDs. This could be quite inefficient when we
have millions of containers. I see an existing function
SCMContainerManager#getContainers just below that one which looks inefficient.
This also needs to be fixed too.
Reviewing the ReplicationManager class...
> Refactor ReplicationManager to handle QUASI_CLOSED containers
> -------------------------------------------------------------
>
> Key: HDDS-1205
> URL: https://issues.apache.org/jira/browse/HDDS-1205
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Priority: Major
> Attachments: HDDS-1205.000.patch, HDDS-1205.001.patch,
> HDDS-1205.002.patch
>
>
> This Jira is for refactoring the ReplicationManager code to handle all the
> scenarios that are possible with the introduction of QUASI_CLOSED state of a
> container.
> The new ReplicationManager will go through the complete set of containers in
> SCM to find out under/over replicated and unhealthy containers and takes
> appropriate action.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
