[
https://issues.apache.org/jira/browse/HDDS-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aravindan Vijayan updated HDDS-1234:
------------------------------------
Attachment: HDDS-1234-002.patch
Status: Patch Available (was: Open)
Thanks for the review [~swagle]. Attached patch addressing most of your
suggestions.
* scheduleReconTasks(Injector injector): - *Fixed*
* <minor> getCountForForContainerKeyPrefix(): For readability,
Integer.valueOf(0)
* getKeyPrefixesForContainer# 145: Seems null check should be needed,
containerIterator.next().getKey() - *We have iter.hasNext before this. So this
is not needed*
* ContainerKeyMapperTask(): Dependencies could be injected here. -
_Since this a very specific class that will not any other uses, I did not link
this to the injector. Maybe we can revisit this later._
* <minor> TestHelper: suggest reame to TestReconOMHelper - *Fixed*
* <minor> Instead of TestHelper defining static methods, I would create a base
abstract class that hides behavior of creating temp location and db completely.
- *Fixed*
> Iterate the OM DB snapshot and populate the recon container DB.
> ----------------------------------------------------------------
>
> Key: HDDS-1234
> URL: https://issues.apache.org/jira/browse/HDDS-1234
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Recon
> Reporter: Aravindan Vijayan
> Assignee: Aravindan Vijayan
> Priority: Major
> Fix For: 0.5.0
>
> Attachments: HDDS-1234-000.patch, HDDS-1234-001.patch,
> HDDS-1234-002.patch
>
>
> * OM DB snapshot contains the Key->ContainerId + BlockId information.
> * Iterate the OM snapshot DB and create the reverse map of (ContainerId, Key
> prefix) -> Key count to be stored in the Recon container DB.
> * Use a codec to store data into Recon container DB.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
