[
https://issues.apache.org/jira/browse/HDDS-1291?focusedWorklogId=217430&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-217430
]
ASF GitHub Bot logged work on HDDS-1291:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Mar/19 20:58
Start Date: 22/Mar/19 20:58
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #639: HDDS-1291. Set
OmKeyArgs#refreshPipeline flag properly to avoid readi…
URL: https://github.com/apache/hadoop/pull/639#issuecomment-475780550
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 40 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 14 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 77 | Maven dependency ordering for branch |
| +1 | mvninstall | 1260 | trunk passed |
| +1 | compile | 100 | trunk passed |
| +1 | checkstyle | 26 | trunk passed |
| +1 | mvnsite | 118 | trunk passed |
| +1 | shadedclient | 864 | branch has no errors when building and testing
our client artifacts. |
| 0 | findbugs | 0 | Skipped patched modules with no Java source:
hadoop-ozone/integration-test |
| +1 | findbugs | 107 | trunk passed |
| +1 | javadoc | 77 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 12 | Maven dependency ordering for patch |
| +1 | mvninstall | 131 | the patch passed |
| +1 | compile | 90 | the patch passed |
| +1 | javac | 90 | the patch passed |
| +1 | checkstyle | 22 | the patch passed |
| +1 | mvnsite | 95 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 795 | patch has no errors when building and testing
our client artifacts. |
| 0 | findbugs | 0 | Skipped patched modules with no Java source:
hadoop-ozone/integration-test |
| +1 | findbugs | 126 | the patch passed |
| +1 | javadoc | 68 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 25 | client in the patch passed. |
| +1 | unit | 41 | ozone-manager in the patch passed. |
| +1 | unit | 23 | objectstore-service in the patch passed. |
| -1 | unit | 580 | integration-test in the patch failed. |
| +1 | asflicense | 28 | The patch does not generate ASF License warnings. |
| | | 4737 | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-639/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/639 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux d977d191598f 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed
Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 509b20b |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-639/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-639/1/testReport/ |
| Max. process+thread count | 4022 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/client hadoop-ozone/ozone-manager
hadoop-ozone/objectstore-service hadoop-ozone/integration-test U: hadoop-ozone |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-639/1/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 217430)
Time Spent: 20m (was: 10m)
> Set OmKeyArgs#refreshPipeline flag properly to avoid reading from stale
> pipeline
> --------------------------------------------------------------------------------
>
> Key: HDDS-1291
> URL: https://issues.apache.org/jira/browse/HDDS-1291
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Priority: Blocker
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> After HDDS-1138, the OM client will not talk to SCM directly to fetch the
> pipeline info. Instead the pipeline info is returned as part of the
> keyLocation cached by OM.
>
> In case SCM pipeline is changed such as closed, the client may get invalid
> pipeline exception. In this case, the client need to getKeyLocation with
> OmKeyArgs#refreshPipeline = true to force OM update its pipeline cache for
> this key.
>
> An optimization could be queue a background task to update all the
> keyLocations that is affected when OM does a refreshPipeline. (This part can
> be done in 0.5)
> {code:java}
> oldpipeline->newpipeline{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
