[ 
https://issues.apache.org/jira/browse/HDFS-14320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16799373#comment-16799373
 ] 

Karthik Palanisamy edited comment on HDFS-14320 at 3/22/19 9:36 PM:
--------------------------------------------------------------------

{quote}Also, this patch won't work with security enabled since the NN's handler 
does not have any credentials.
{quote}
[~daryn] It works in secure environment because authentication token will send 
to Webhdfs server, where we do doAs with this credentials.  Tested this patch 
in Secure cluster. 

NamenodeWebHdfsMethods#delete
{code:java}
return doAs(ugi, new PrivilegedExceptionAction<Response>() {
  @Override
  public Response run() throws IOException {
      return delete(ugi, delegation, username, doAsUser,
          path.getAbsolutePath(), op, recursive, skiptrash, snapshotName);
  }
{code}
Btw, yes I should not use Filesystem object,  will use direct rename(trash) 
call to Namenode.

 

 


was (Author: kpalanisamy):
{quote}Also, this patch won't work with security enabled since the NN's handler 
does not have any credentials.
{quote}
[~daryn] It works in secure environment because authentication token will send 
to Webhdfs server, where we do doAs with this credentials.  Tested this patch 
in Secure cluster. 

NamenodeWebHdfsMethods#delete
{code:java}
return doAs(ugi, new PrivilegedExceptionAction<Response>() {
  @Override
  public Response run() throws IOException {
      return delete(ugi, delegation, username, doAsUser,
          path.getAbsolutePath(), op, recursive, skiptrash, snapshotName);
  }
{code}
Btw, yes I should not Filesystem object,  will use direct rename(trash) call to 
Namenode.

 

 

> Support skipTrash for WebHDFS 
> ------------------------------
>
>                 Key: HDFS-14320
>                 URL: https://issues.apache.org/jira/browse/HDFS-14320
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: namenode, webhdfs
>    Affects Versions: 3.2.0
>            Reporter: Karthik Palanisamy
>            Assignee: Karthik Palanisamy
>            Priority: Major
>         Attachments: HDFS-14320-001.patch, HDFS-14320-002.patch, 
> HDFS-14320-003.patch, HDFS-14320-004.patch, HDFS-14320-005.patch, 
> HDFS-14320-006.patch, HDFS-14320-007.patch, HDFS-14320-008.patch
>
>
> Files/Directories deleted via webhdfs rest call doesn't use the skiptrash 
> feature, it would be deleted permanently. This feature is very important us 
> because our user has deleted large directory accidentally.
> By default, Skiptrash option is set to true, skiptrash=true. Any files, Using 
> CURL will be permanently deleted.
> Example:
> curl -iv -X DELETE 
> "http://xxxx:50070/webhdfs/v1/tmp/sampledata?op=DELETE&user.name=hdfs&recursive=true";
>  
> Use skiptrash=false, to move files to trash Instead.
> Example:
> curl -iv -X DELETE 
> "http://xxxx:50070/webhdfs/v1/tmp/sampledata?op=DELETE&user.name=hdfs&recursive=true&skiptrash=false";
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to