[
https://issues.apache.org/jira/browse/HDDS-939?focusedWorklogId=217523&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-217523
]
ASF GitHub Bot logged work on HDDS-939:
---------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/19 00:56
Start Date: 23/Mar/19 00:56
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #634: HDDS-939. Add S3
access check to Ozone manager. Contributed by Ajay Kumar.
URL: https://github.com/apache/hadoop/pull/634#issuecomment-475825432
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 27 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 48 | Maven dependency ordering for branch |
| +1 | mvninstall | 977 | trunk passed |
| +1 | compile | 94 | trunk passed |
| +1 | checkstyle | 30 | trunk passed |
| +1 | mvnsite | 70 | trunk passed |
| +1 | shadedclient | 763 | branch has no errors when building and testing
our client artifacts. |
| +1 | findbugs | 99 | trunk passed |
| +1 | javadoc | 60 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 14 | Maven dependency ordering for patch |
| +1 | mvninstall | 71 | the patch passed |
| +1 | compile | 91 | the patch passed |
| +1 | javac | 91 | the patch passed |
| +1 | checkstyle | 24 | the patch passed |
| +1 | mvnsite | 58 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 729 | patch has no errors when building and testing
our client artifacts. |
| -1 | findbugs | 43 | hadoop-ozone/s3gateway generated 1 new + 0 unchanged
- 0 fixed = 1 total (was 0) |
| +1 | javadoc | 51 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 31 | common in the patch passed. |
| -1 | unit | 34 | s3gateway in the patch failed. |
| +1 | asflicense | 25 | The patch does not generate ASF License warnings. |
| | | 3463 | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-ozone/s3gateway |
| | Return value of java.util.Objects.nonNull(Object) ignored, but method
has no side effect At OzoneS3Util.java:but method has no side effect At
OzoneS3Util.java:[line 33] |
| Failed junit tests | hadoop.ozone.s3.endpoint.TestRootList |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-634/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/634 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux f754d11f6904 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 43e421a |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-634/3/artifact/out/new-findbugs-hadoop-ozone_s3gateway.html
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-634/3/artifact/out/patch-unit-hadoop-ozone_s3gateway.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-634/3/testReport/ |
| Max. process+thread count | 446 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/common hadoop-ozone/s3gateway U: hadoop-ozone |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-634/3/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 217523)
Time Spent: 1h 20m (was: 1h 10m)
> Add S3 access check to Ozone manager
> ------------------------------------
>
> Key: HDDS-939
> URL: https://issues.apache.org/jira/browse/HDDS-939
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Manager, S3
> Reporter: Anu Engineer
> Assignee: Ajay Kumar
> Priority: Blocker
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Add the mapping from S3 User Identity to UGI inside Ozone Manager. Also add
> the access check permission, that is call into the checkAccess, which will be
> intercepted by Ranger or Ozone access check.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
