[
https://issues.apache.org/jira/browse/HDDS-1299?focusedWorklogId=218098&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-218098
]
ASF GitHub Bot logged work on HDDS-1299:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/19 15:47
Start Date: 25/Mar/19 15:47
Worklog Time Spent: 10m
Work Description: steveloughran commented on issue #627: HDDS-1299.
Support TokenIssuer interface for running jobs with OzoneFileSystem.
URL: https://github.com/apache/hadoop/pull/627#issuecomment-476256841
Given this has broken things, can I ask a process question here,
specifically regarding Yetus's v-1
> The patch doesn't appear to include any new or modified tests. Please
justify why no new tests are needed for this patch. Also please list what
manual steps were performed to verify this patch.
There are lots of ways to test for DTs being ussued: The `hdfs fs` command,
the `hadoop dtuils`, the actualyh M
* Marshalling/unmarshalling of tokens:
org.apache.hadoop.fs.s3a.auth.delegation.TestS3ADelegationTokenSupport
* org.apache.hadoop.fs.s3a.auth.delegation.ITestRoleDelegationTokens
* org.apache.hadoop.fs.s3a.auth.delegation.ITestRoleDelegationInFileystem
* org.apache.hadoop.fs.azurebfs.extensions.ITestAbfsDelegationTokens
You can even verify that MR cluster launch collects the tokens:
org.apache.hadoop.fs.s3a.auth.delegation.ITestDelegatedMRJob
Please. write tests. Apart from the MR job one its straightforward, and I've
just given you all the clases to start with.
Without tests, when people like myself make an incompatible change which
breaks Ozone's DT support, we're just going to shrug and say "well, you should
have written the tests"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 218098)
Time Spent: 6h 20m (was: 6h 10m)
> Support TokenIssuer interface for running jobs with OzoneFileSystem
> -------------------------------------------------------------------
>
> Key: HDDS-1299
> URL: https://issues.apache.org/jira/browse/HDDS-1299
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 0.4.0
>
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> This ticket is opened to add TokenIssuer interface support to OzoneFileSystem
> so that MR and Spark jobs can run with OzoneFileSystem in secure mode.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]