[ 
https://issues.apache.org/jira/browse/HDDS-1340?focusedWorklogId=219421&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-219421
 ]

ASF GitHub Bot logged work on HDDS-1340:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Mar/19 16:35
            Start Date: 27/Mar/19 16:35
    Worklog Time Spent: 10m 
      Work Description: avijayanhwx commented on pull request #648: HDDS-1340. 
Add List Containers API for Recon
URL: https://github.com/apache/hadoop/pull/648#discussion_r269657755
 
 

 ##########
 File path: 
hadoop-ozone/ozone-recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/ContainerDBServiceProviderImpl.java
 ##########
 @@ -163,4 +165,21 @@ public Integer getCountForForContainerKeyPrefix(
     return prefixes;
   }
 
+  /**
+   * Iterate the DB to construct a unique set of containerIDs.
+   *
+   * @return List of containerIDs.
+   * @throws IOException
+   */
+  @Override
+  public Set<Long> getContainerIDList() throws IOException {
+    Set<Long> containerIDs = new HashSet<>();
 
 Review comment:
   (Minor) LinkedHashSet may be better if we want to preserve containerId 
ordering on iteration.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 219421)
    Time Spent: 2h  (was: 1h 50m)

> Add List Containers API for Recon
> ---------------------------------
>
>                 Key: HDDS-1340
>                 URL: https://issues.apache.org/jira/browse/HDDS-1340
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: Ozone Recon
>            Reporter: Vivek Ratnavel Subramanian
>            Assignee: Vivek Ratnavel Subramanian
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Recon server should support "/containers" API that lists all the containers



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to