[
https://issues.apache.org/jira/browse/HDDS-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804747#comment-16804747
]
Mukul Kumar Singh commented on HDDS-1312:
-----------------------------------------
Thanks for working on this [~shashikant]. The patch looks really good to me.
Some minor comments.
1) TestBlockOutputStreamWithFailures:990, the comment need to be corrected.
2) TestBlockOutputStreamWithFailures:1039, the comment is incomplete.
3) TestBlockOutputStreamWithFailures:1058, after the flush we will have 2
entries in the keyoutput stream, one for the max flush and one for the 50 bytes
after the flush. Any further writes should we written into a new block because
the datanode is closed.
4) TestBlockOutputStreamWithFailures:1188, with Single node ratis, the blocks
might not be allocated from the same pipeline. So any exceptions might not
happen on restart.
> Add more unit tests to verify BlockOutputStream functionalities
> ---------------------------------------------------------------
>
> Key: HDDS-1312
> URL: https://issues.apache.org/jira/browse/HDDS-1312
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Blocker
> Attachments: HDDS-1312.000.patch, HDDS-1312.001.patch
>
>
> This jira aims to add more unit test coverage for BlockOutputStream
> functionalities.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
