[
https://issues.apache.org/jira/browse/HDDS-1339?focusedWorklogId=220901&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-220901
]
ASF GitHub Bot logged work on HDDS-1339:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/19 17:36
Start Date: 30/Mar/19 17:36
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #651:
HDDS-1339. Implement ratis snapshots on OM
URL: https://github.com/apache/hadoop/pull/651#discussion_r270634511
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java
##########
@@ -161,7 +161,10 @@ public TransactionContext startTransaction(
@Override
public long takeSnapshot() throws IOException {
LOG.info("Saving Ratis snapshot on the OM.");
- return ozoneManager.saveRatisSnapshot();
+ if (ozoneManager != null) {
+ return ozoneManager.saveRatisSnapshot();
+ }
+ return 0;
Review comment:
Question: Here we are returning 0,(Should we return the lastAppliedIndex we
are writing) How this will be used by Ratis?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 220901)
Time Spent: 2.5h (was: 2h 20m)
> Implement Ratis Snapshots on OM
> -------------------------------
>
> Key: HDDS-1339
> URL: https://issues.apache.org/jira/browse/HDDS-1339
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> For bootstrapping and restarting OMs, we need to implement snapshots in OM.
> The OM state maintained by RocksDB will be checkpoint-ed on demand. Ratis
> snapshots will only preserve the last applied log index by the State Machine
> on disk. This index will be stored in file in the OM metadata dir.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
