[
https://issues.apache.org/jira/browse/HDDS-1153?focusedWorklogId=221295&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221295
]
ASF GitHub Bot logged work on HDDS-1153:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/19 14:18
Start Date: 01/Apr/19 14:18
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #673: HDDS-1153. Make
tracing instrumentation configurable
URL: https://github.com/apache/hadoop/pull/673#issuecomment-478598550
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 35 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 93 | Maven dependency ordering for branch |
| -1 | mvninstall | 1098 | root in trunk failed. |
| +1 | compile | 1033 | trunk passed |
| +1 | checkstyle | 190 | trunk passed |
| +1 | mvnsite | 256 | trunk passed |
| +1 | shadedclient | 1123 | branch has no errors when building and testing
our client artifacts. |
| +1 | findbugs | 312 | trunk passed |
| +1 | javadoc | 204 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 25 | Maven dependency ordering for patch |
| +1 | mvninstall | 190 | the patch passed |
| +1 | compile | 949 | the patch passed |
| +1 | javac | 949 | the patch passed |
| +1 | checkstyle | 207 | the patch passed |
| +1 | mvnsite | 225 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | xml | 2 | The patch has no ill-formed XML file. |
| +1 | shadedclient | 626 | patch has no errors when building and testing
our client artifacts. |
| +1 | findbugs | 399 | the patch passed |
| +1 | javadoc | 227 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 89 | common in the patch passed. |
| +1 | unit | 35 | tools in the patch passed. |
| +1 | unit | 40 | client in the patch passed. |
| +1 | unit | 48 | common in the patch passed. |
| +1 | unit | 40 | objectstore-service in the patch passed. |
| +1 | unit | 55 | ozone-manager in the patch passed. |
| +1 | asflicense | 49 | The patch does not generate ASF License warnings. |
| | | 7413 | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-673/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/673 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle xml |
| uname | Linux 325e602832c1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 8bfef21 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-673/1/artifact/out/branch-mvninstall-root.txt
|
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-673/1/testReport/ |
| Max. process+thread count | 410 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common hadoop-hdds/tools hadoop-ozone/client
hadoop-ozone/common hadoop-ozone/objectstore-service hadoop-ozone/ozone-manager
U: . |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-673/1/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 221295)
Time Spent: 20m (was: 10m)
> Make tracing instrumentation configurable
> -----------------------------------------
>
> Key: HDDS-1153
> URL: https://issues.apache.org/jira/browse/HDDS-1153
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Kitti Nanasi
> Priority: Major
> Labels: newbie, pull-request-available
> Attachments: HDDS-1153.001.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> TracingUtil.createProxy is a helper method to create a proxy instance with
> tracing support.
> The proxy instance implements the same interface as the original class and
> delegates all the method calls to the original instance but it also sends
> tracing information to the tracing server.
> By default it's not a big overhead as the tracing libraries can be configured
> to send tracing only with some low probability.
> But to make it more safe we can make it optional. With a global
> 'hdds.tracing.enabled' configuration variable (can be true by default) we can
> adjust the behavior of TracingUtil.createProxy.
> If the tracing is disabled the TracingUtil.createProxy should return with the
> 'delegate' parameter instead of a proxy.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
