[
https://issues.apache.org/jira/browse/HDDS-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806880#comment-16806880
]
Yiqun Lin commented on HDDS-1337:
---------------------------------
The patch looks good, some minor comments for the UTS:
*TestOzoneClientRetriesOnException#testMaxRetriesByOzoneClient*
{code}
+ try {
+ key.write(data1);
+ Assert.assertTrue(keyOutputStream.checkForException(blockOutputStream
+ .getIoException()) instanceof GroupMismatchException);
+ } catch (IOException ioe) {
+ Assert.assertTrue(ioe.getMessage().contains(
+ "Retry request failed. retries get failed due to exceeded maximum
allowed retries number: 3"));
+ }
{code}
Once the IO exception was thrown, the condition check
{{keyOutputStream.checkForException}} cannot reach.
*ContainerTestHelper*
{code}
+ System.out.println("Pipeline exist " + raftServer.getPipelineIds()
+ .contains(pipeline.getId()));
+ /* GenericTestUtils.waitFor(
+ () -> (!raftServer.getPipelineIds()
+ .contains(pipeline.getId())), 500, 100 * 1000 );*/
{code}
Two nits:
* Can er use LOG instance to print?
* Remove {{GenericTestUtils#waitFor}} redundant lines.
BTW, there are some remaining check style issues need to be fixed. Pending
Jenkins.
> HandleGroupMismatchException in OzoneClient
> -------------------------------------------
>
> Key: HDDS-1337
> URL: https://issues.apache.org/jira/browse/HDDS-1337
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Client
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Blocker
> Labels: Blocker
> Fix For: 0.4.0
>
> Attachments: HDDS-1337.000.patch, HDDS-1337.001.patch,
> HDDS-1337.002.patch, HDDS-1337.003.patch
>
>
> If a pipeline gets destroyed in ozone client, ozone client may hit
> GroupMismatchException from Ratis. In cases as such, client should exclude
> the pipeline and retry write to a different block.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
