[
https://issues.apache.org/jira/browse/HDFS-13699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807295#comment-16807295
]
Konstantin Shvachko commented on HDFS-13699:
--------------------------------------------
Chen, thanks for the comprehensive analysis of upgrade scenarios. Sounds like
we should not have unexpected failures during rolling upgrades.
??DFSClient code has many Perconditions checks??
We should stop using Preconditions as a substitute for java {{assert}}.
{{assert}} conditions are not even included in the binaries when compiled for
execution in production, while Preconditions are always executed. So if only
for performance reasons we should prefer asserts. Another reason is that
Preconditions is the major use case for Guava in Hadoop, and we could not
neither upgrade nor get rid of it for a long time. So it's an anti-pattern,
which we should avoid replicating.
And in tests we use junit Asserts.
# Check the style warnings, some of them can be fixed.
# Unused imports: DNConf, SaslDataTransferServer,
# Avoid *-imports like in TestMultipleNNPortQOP:
{code}
import static org.apache.hadoop.hdfs.DFSConfigKeys.*;
import static org.apache.hadoop.hdfs.client.HdfsClientConfigKeys.*;
import static org.junit.Assert.*;
{code}
> Add DFSClient sending handshake token to DataNode, and allow DataNode
> overwrite downstream QOP
> ----------------------------------------------------------------------------------------------
>
> Key: HDFS-13699
> URL: https://issues.apache.org/jira/browse/HDFS-13699
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chen Liang
> Assignee: Chen Liang
> Priority: Major
> Attachments: HDFS-13699.001.patch, HDFS-13699.002.patch,
> HDFS-13699.003.patch, HDFS-13699.004.patch, HDFS-13699.005.patch,
> HDFS-13699.006.patch, HDFS-13699.007.patch, HDFS-13699.008.patch,
> HDFS-13699.WIP.001.patch
>
>
> Given the other Jiras under HDFS-13541, this Jira is to allow DFSClient to
> redirect the encrypt secret to DataNode. The encrypted message is the QOP
> that client and NameNode have used. DataNode decrypts the message and enforce
> the QOP for the client connection. Also, this Jira will also include
> overwriting downstream QOP, as mentioned in the HDFS-13541 design doc.
> Namely, this is to allow inter-DN QOP that is different from client-DN QOP.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
