[
https://issues.apache.org/jira/browse/HDDS-1355?focusedWorklogId=221580&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221580
]
ASF GitHub Bot logged work on HDDS-1355:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/19 01:35
Start Date: 02/Apr/19 01:35
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #677: HDDS-1355. Only
FQDN is accepted for OM rpc address in secure environment. Contributed by Ajay
Kumar.
URL: https://github.com/apache/hadoop/pull/677#issuecomment-478809174
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 25 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 1 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 57 | Maven dependency ordering for branch |
| +1 | mvninstall | 1091 | trunk passed |
| +1 | compile | 104 | trunk passed |
| +1 | checkstyle | 28 | trunk passed |
| +1 | mvnsite | 75 | trunk passed |
| +1 | shadedclient | 758 | branch has no errors when building and testing
our client artifacts. |
| 0 | findbugs | 0 | Skipped patched modules with no Java source:
hadoop-ozone/integration-test |
| +1 | findbugs | 46 | trunk passed |
| +1 | javadoc | 46 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 13 | Maven dependency ordering for patch |
| +1 | mvninstall | 70 | the patch passed |
| +1 | compile | 93 | the patch passed |
| +1 | javac | 93 | the patch passed |
| +1 | checkstyle | 21 | the patch passed |
| +1 | mvnsite | 52 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 690 | patch has no errors when building and testing
our client artifacts. |
| 0 | findbugs | 0 | Skipped patched modules with no Java source:
hadoop-ozone/integration-test |
| +1 | findbugs | 43 | the patch passed |
| +1 | javadoc | 30 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 39 | ozone-manager in the patch passed. |
| -1 | unit | 1078 | integration-test in the patch failed. |
| +1 | asflicense | 29 | The patch does not generate ASF License warnings. |
| | | 4439 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.ozone.TestMiniChaosOzoneCluster |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-677/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/677 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux a86d61a09e9b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / ab2bda5 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-677/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-677/1/testReport/ |
| Max. process+thread count | 4992 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U:
hadoop-ozone |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-677/1/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 221580)
Time Spent: 20m (was: 10m)
> Only FQDN is accepted for OM rpc address in secure environment
> --------------------------------------------------------------
>
> Key: HDDS-1355
> URL: https://issues.apache.org/jira/browse/HDDS-1355
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Ajay Kumar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> While the scm address can be a host name (relative to the current search
> domain) if the om address is just a hostname and not a FQDN a NPE is thrown:
> {code}
> 10 │ OZONE-SITE.XML_ozone.om.address: "om-0.om"
> 11 │ OZONE-SITE.XML_ozone.scm.client.address: "scm-0.scm"
> 12 │ OZONE-SITE.XML_ozone.scm.names: "scm-0.scm"
> {code}
> {code}
> 2019-03-29 14:37:52 ERROR OzoneManager:865 - Failed to start the OzoneManager.
> java.lang.NullPointerException
> at
> org.apache.hadoop.ozone.om.OzoneManager.getSCMSignedCert(OzoneManager.java:1372)
> at
> org.apache.hadoop.ozone.om.OzoneManager.initializeSecurity(OzoneManager.java:1018)
> at org.apache.hadoop.ozone.om.OzoneManager.omInit(OzoneManager.java:971)
> at org.apache.hadoop.ozone.om.OzoneManager.createOm(OzoneManager.java:928)
> at org.apache.hadoop.ozone.om.OzoneManager.main(OzoneManager.java:859)
> {code}
> I don't know what is the right validation rule here, but I am pretty sure
> that NPE should be avoided and a meaningful error should be thrown. (and the
> behaviour should be the same for scm and om)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
