[ 
https://issues.apache.org/jira/browse/HDDS-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16808391#comment-16808391
 ] 

Yiqun Lin commented on HDDS-1365:
---------------------------------

Hi [~sdeka],
bq. When that happens, we can introduce a specific new exception for every such 
specialised category with its own handler logic.
I agree on this, maybe we can define a new exception similar to 
StorageContainerException.
We can temporarily commit this change. +1.
 

> Fix error handling in KeyValueContainerCheck
> --------------------------------------------
>
>                 Key: HDDS-1365
>                 URL: https://issues.apache.org/jira/browse/HDDS-1365
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: Ozone Datanode
>            Reporter: Supratim Deka
>            Assignee: Supratim Deka
>            Priority: Major
>         Attachments: HDDS-1365.000.patch
>
>
> Error handling and propagation in KeyValueContainerCheck needs to be based on 
> throwing IOException instead of passing an error code to the calling function.
> HDDS-1163 implemented the basic framework using a mix of error code return 
> and exception handling. There is added complexity because exceptions deep 
> inside the call chain are being caught and translated to error code return 
> values. The goal is to change all error handling in this class to use 
> Exceptions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to