[
https://issues.apache.org/jira/browse/HDFS-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119837#comment-13119837
]
Suresh Srinivas commented on HDFS-2181:
---------------------------------------
Comments:
# DFSClient should just call DFSUtil#createNameNode()
# closeConnectionToNameNode() comments in the method is not clear, it abruptly
ends. Do we need that comment?
# minor: DFSUtil some code is beyond 80 lines. You could also import
ClientProtocolDatanodeTranslator.
# DatanodeInfo.java - Call existing constructor from newly introduced
constructor
# NamenodeRpcServer - newly added code indentation is not consistent with the
rest of the code
Can you please comment on rest of the changes you are planning to do and when.
For example all protocol package classes need not be writable etc.
> Seperate HDFS wire protocol data types
> --------------------------------------
>
> Key: HDFS-2181
> URL: https://issues.apache.org/jira/browse/HDFS-2181
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Attachments: separateDataType1.patch, separateDataType10.patch,
> separateDataType11.patch, separateDataType12.patch, separateDataType13.patch,
> separateDataType14.patch, separateDataType2.patch, separateDataType6.patch,
> separateDataType7.patch, separateDataType8.patch, separateDataType9.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
