[
https://issues.apache.org/jira/browse/HDDS-1398?focusedWorklogId=223829&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223829
]
ASF GitHub Bot logged work on HDDS-1398:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/19 20:22
Start Date: 05/Apr/19 20:22
Worklog Time Spent: 10m
Work Description: arp7 commented on pull request #697: HDDS-1398.
Concurrency issue in SCMConnectionManager#getValues
URL: https://github.com/apache/hadoop/pull/697
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 223829)
Time Spent: 20m (was: 10m)
> Concurrency issue in SCMConnectionManager#getValues
> ---------------------------------------------------
>
> Key: HDDS-1398
> URL: https://issues.apache.org/jira/browse/HDDS-1398
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{testStartStopDatanodeStateMachine}} is flaky, causing [occasional
> pre-commit build
> failures|https://builds.apache.org/job/hadoop-multibranch/job/PR-691/1/artifact/out/patch-unit-hadoop-hdds_container-service.txt].
> HDDS-1332 added some logging to find out more about the cause.
> I think the problem is not test-specific, and is caused by the following:
> {{SCMConnectionManager#scmMachines}} is a plain {{HashMap}}, guarded by a
> {{ReadWriteLock}} in most places where it's used, except {{getValues()}}.
> The method also returns the values collection without any write protection
> (though currently none of the callers modify it).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]