[
https://issues.apache.org/jira/browse/HDDS-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Agarwal updated HDDS-1398:
--------------------------------
Resolution: Fixed
Fix Version/s: 0.5.0
Target Version/s: (was: 0.5.0)
Status: Resolved (was: Patch Available)
I've committed this, based on the Jenkins +1 on PR 697.
> Concurrency issue in SCMConnectionManager#getValues
> ---------------------------------------------------
>
> Key: HDDS-1398
> URL: https://issues.apache.org/jira/browse/HDDS-1398
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{testStartStopDatanodeStateMachine}} is flaky, causing [occasional
> pre-commit build
> failures|https://builds.apache.org/job/hadoop-multibranch/job/PR-691/1/artifact/out/patch-unit-hadoop-hdds_container-service.txt].
> HDDS-1332 added some logging to find out more about the cause.
> I think the problem is not test-specific, and is caused by the following:
> {{SCMConnectionManager#scmMachines}} is a plain {{HashMap}}, guarded by a
> {{ReadWriteLock}} in most places where it's used, except {{getValues()}}.
> The method also returns the values collection without any write protection
> (though currently none of the callers modify it).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]