[
https://issues.apache.org/jira/browse/HDDS-1393?focusedWorklogId=224679&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-224679
]
ASF GitHub Bot logged work on HDDS-1393:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/19 23:38
Start Date: 08/Apr/19 23:38
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #704:
HDDS-1393. Convert all OM Bucket related operations to HA model.
URL: https://github.com/apache/hadoop/pull/704#discussion_r273278199
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/S3BucketManagerImpl.java
##########
@@ -141,7 +141,14 @@ public void deleteS3Bucket(String bucketName) throws
IOException {
throw new OMException("No such S3 bucket. " + bucketName,
OMException.ResultCodes.S3_BUCKET_NOT_FOUND);
}
- bucketManager.deleteBucket(getOzoneVolumeName(bucketName), bucketName);
+
+ if (isRatisEnabled) {
Review comment:
Here it should be if Ratis is Enabled, we should call applyTransaction to
persist this info to DB.
As we have not separated this into 2 phase we should do this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 224679)
Time Spent: 50m (was: 40m)
> Convert all OM Bucket related operations to HA model
> ----------------------------------------------------
>
> Key: HDDS-1393
> URL: https://issues.apache.org/jira/browse/HDDS-1393
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In this jira, we shall convert all OM Bucket related operations to OM HA
> model, which is a 2 step.
> # StartTransaction, where we validate request and check for any errors and
> return the response.
> # ApplyTransaction, where original OM request will have a response which
> needs to be applied to OM DB. This step is just to apply response to Om DB.
> In this way, all requests which are failed with like bucket not found or some
> conditions which i have not satisfied like when deleting bucket should be
> empty, these all will be executed during startTransaction, and if it fails
> these requests will not be written to raft log also.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
