[
https://issues.apache.org/jira/browse/HDDS-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813412#comment-16813412
]
Kitti Nanasi commented on HDDS-1192:
------------------------------------
Patch v001 contains the following modifications, I did some additional
refactoring for the unit tests to pass:
* GenericCli now accepts -conf argument
* Usage field is removed from MissingSubcommandException, because now it
derives from CommandLine.ParameterException, which means that when running the
commands with the default exception handler (the default exception handler is
used everywhere except in the tests), picocli will print the usage.
* The startup message is written inside the ozone 'datanode command' and not
in the constructor, so if the command is invalid, it won't print the startup
message.
* I modified that if 'ozone datanode' command is ran by itself, it will not
throw an invalid command exception, it will only fail if it is used with an
invalid argument (like 'ozone datanode -invalidArg'). Let me know if that is
not ok.
Note that the subcommands, like volume and bucket, are not deriving from
GenericCli, so the -conf parameter has to come before those commands like this:
'ozone sh -conf conf volume...'
> Support -conf command line argument in GenericCli
> -------------------------------------------------
>
> Key: HDDS-1192
> URL: https://issues.apache.org/jira/browse/HDDS-1192
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Kitti Nanasi
> Priority: Major
> Labels: newbie, pull-request-available
> Attachments: HDDS-1192.001.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> org.apache.hadoop.hdds.GenericCli is the based class for all the Ozone
> related command line application. It supports to define custom configuration
> variables (-D or --set) but doesn't support the '--conf ozone-site.xml'
> argument to load an external xml file to the configuration.
> Configuration and OzoneConfiguration classes load the ozone-site.xml from the
> classpath. But it makes very hard to start Ozone components in IDE as we
> can't modify the classpath easily.
> One option here is to support the --conf everywhere to make it possible to
> start ozone cluster in the IDE.
> Note: It's a nice to have for 0.4.0. I marked it as 0.5.0 but safe to commit
> at anytime to 0.4.0
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
