[
https://issues.apache.org/jira/browse/HDFS-14401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814365#comment-16814365
]
Anoop Sam John commented on HDFS-14401:
---------------------------------------
PmemVolumeManager#reserve is synchronized whereas release not !
chooseVolume -> synchronized Any reason why and not the counter variable is
Atomic alone?
blockKeyToVolume.put(key, index);
What is the heap size requirement for this Map? Per entry? Need some math
which will be useful.
private final Long maxBytes;
Reason why not long but Long?
static PmemVolumeManager getPmemVolumeManager() {
Can we avoid static getters? Can we have a singleton model?
> Refine the implementation for HDFS cache on SCM
> -----------------------------------------------
>
> Key: HDFS-14401
> URL: https://issues.apache.org/jira/browse/HDFS-14401
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: caching, datanode
> Reporter: Feilong He
> Assignee: Feilong He
> Priority: Major
> Attachments: HDFS-14401.000.patch
>
>
> In this Jira, we will refine the implementation for HDFS cache on SCM, such
> as: 1) Handle full pmem volume in VolumeManager; 2) Refine pmem volume
> selection impl; 3) Clean up MapppableBlockLoader interface; etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
