[
https://issues.apache.org/jira/browse/HDDS-1412?focusedWorklogId=225716&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-225716
]
ASF GitHub Bot logged work on HDDS-1412:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Apr/19 17:08
Start Date: 10/Apr/19 17:08
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #719: HDDS-1412.
Provide example k8s deployment files as part of the release package
URL: https://github.com/apache/hadoop/pull/719#issuecomment-481778437
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 32 | Docker mode activated. |
||| _ Prechecks _ |
| 0 | yamllint | 0 | yamllint was not available. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 38 | Maven dependency ordering for branch |
| +1 | mvninstall | 1123 | trunk passed |
| +1 | compile | 132 | trunk passed |
| +1 | mvnsite | 88 | trunk passed |
| +1 | shadedclient | 634 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 68 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 17 | Maven dependency ordering for patch |
| -1 | mvninstall | 23 | dist in the patch failed. |
| +1 | compile | 114 | the patch passed |
| +1 | javac | 114 | the patch passed |
| +1 | hadolint | 0 | There were no new hadolint issues. |
| +1 | mvnsite | 54 | the patch passed |
| +1 | shellcheck | 0 | There were no new shellcheck issues. |
| +1 | shelldocs | 13 | The patch generated 0 new + 104 unchanged - 132
fixed = 104 total (was 236) |
| -1 | whitespace | 0 | The patch has 3 line(s) that end in whitespace. Use
git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| +1 | xml | 2 | The patch has no ill-formed XML file. |
| +1 | shadedclient | 728 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 60 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 39 | common in the patch passed. |
| +1 | unit | 26 | dist in the patch passed. |
| +1 | asflicense | 33 | The patch does not generate ASF License warnings. |
| | | 3427 | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-719/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/719 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml hadolint shellcheck shelldocs yamllint |
| uname | Linux c86b1f6071eb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 65deb1a |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| shellcheck | v0.4.6 |
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-719/1/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
|
| whitespace |
https://builds.apache.org/job/hadoop-multibranch/job/PR-719/1/artifact/out/whitespace-eol.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-719/1/testReport/ |
| Max. process+thread count | 467 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/common hadoop-ozone/dist U: hadoop-ozone |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-719/1/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 225716)
Time Spent: 50m (was: 40m)
> Provide example k8s deployment files as part of the release package
> -------------------------------------------------------------------
>
> Key: HDDS-1412
> URL: https://issues.apache.org/jira/browse/HDDS-1412
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In HDDS-872 we added Dockerfile and skaffold definition to run dev builds on
> kubernetes. But it would be great to include example k8s resource definitions
> helping the deployment of ozone to any kubernetes cluster.
> In this patch I will
> 1. Add k8s resources files to the release tar file to deploy basic ozone
> cluster
> 2. Add Dockerfile to the release tar file to create custom ozone image any
> time
> 3. Add additional maven profiles to build and push development docker images.
> 4. We don't need skaffold any more as the maven based approach is more
> flexible (we can support multiple k8s definitions)
> To easily support multiple type of configuration (simple ozone, minikube,
> csi) we need a basic set of k8s resources files and additional
> transformations to generate the ready-to-use files for each specific
> use-cases.
> The easiest way to do this is adopting the existing structure from
> https://github.com/flokkr/k8s and use https://github.com/elek/flekszible
> tool. But the tool itself is not required at runtime as we generate all the
> required k8s resources files during the development and add the results to
> the version control.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]