[ 
https://issues.apache.org/jira/browse/HDDS-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814725#comment-16814725
 ] 

Jitendra Nath Pandey commented on HDDS-1348:
--------------------------------------------

{quote}Already exposed for testing by 
BlockOutputStream#getCommitWatcher#getCommitIndex2flushedDataMap()
{quote}
Let's annotate {{CommitWatcher#getCommitIndex2flushedDataMap}} as well with 
{{VisibleForTesting}}. This can be done while committing.

+1 for the patch, if test failures are not related.

> Refactor BlockOutpuStream Class
> -------------------------------
>
>                 Key: HDDS-1348
>                 URL: https://issues.apache.org/jira/browse/HDDS-1348
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: Ozone Client
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>            Priority: Major
>             Fix For: 0.5.0
>
>         Attachments: HDDS-1348.000.patch, HDDS-1348.001.patch
>
>
> BlockOutputStream contains functionalities for handling write, flush and 
> close as well as tracking commitIndexes . The idea is to separate all 
> commitIndex tracking and management code outside of BlockOutputStream class



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to