[
https://issues.apache.org/jira/browse/HDDS-1192?focusedWorklogId=226365&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-226365
]
ASF GitHub Bot logged work on HDDS-1192:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/19 21:26
Start Date: 11/Apr/19 21:26
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #713: HDDS-1192.
Support -conf command line argument in GenericCli
URL: https://github.com/apache/hadoop/pull/713#issuecomment-482327514
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 27 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 2 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 84 | Maven dependency ordering for branch |
| +1 | mvninstall | 1865 | trunk passed |
| +1 | compile | 2200 | trunk passed |
| +1 | checkstyle | 281 | trunk passed |
| +1 | mvnsite | 245 | trunk passed |
| +1 | shadedclient | 1420 | branch has no errors when building and testing
our client artifacts. |
| 0 | findbugs | 0 | Skipped patched modules with no Java source:
hadoop-ozone/integration-test |
| +1 | findbugs | 744 | trunk passed |
| +1 | javadoc | 565 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 35 | Maven dependency ordering for patch |
| +1 | mvninstall | 469 | the patch passed |
| +1 | compile | 1673 | the patch passed |
| +1 | javac | 1673 | the patch passed |
| +1 | checkstyle | 231 | the patch passed |
| +1 | mvnsite | 349 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 1268 | patch has no errors when building and testing
our client artifacts. |
| 0 | findbugs | 0 | Skipped patched modules with no Java source:
hadoop-ozone/integration-test |
| +1 | findbugs | 858 | the patch passed |
| +1 | javadoc | 775 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 101 | common in the patch passed. |
| +1 | unit | 69 | container-service in the patch passed. |
| +1 | unit | 30 | tools in the patch passed. |
| -1 | unit | 883 | integration-test in the patch failed. |
| +1 | unit | 56 | ozone-manager in the patch passed. |
| +1 | asflicense | 45 | The patch does not generate ASF License warnings. |
| | | 14428 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests |
hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException |
| | hadoop.ozone.ozShell.TestOzoneDatanodeShell |
| | hadoop.ozone.TestMiniChaosOzoneCluster |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-713/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/713 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 933c32650117 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed
Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / a0468c5 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-713/2/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-713/2/testReport/ |
| Max. process+thread count | 3886 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common hadoop-hdds/container-service
hadoop-hdds/tools hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: .
|
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-713/2/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 226365)
Time Spent: 50m (was: 40m)
> Support -conf command line argument in GenericCli
> -------------------------------------------------
>
> Key: HDDS-1192
> URL: https://issues.apache.org/jira/browse/HDDS-1192
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Kitti Nanasi
> Priority: Major
> Labels: newbie, pull-request-available
> Attachments: HDDS-1192.001.patch, HDDS-1192.002.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> org.apache.hadoop.hdds.GenericCli is the based class for all the Ozone
> related command line application. It supports to define custom configuration
> variables (-D or --set) but doesn't support the '--conf ozone-site.xml'
> argument to load an external xml file to the configuration.
> Configuration and OzoneConfiguration classes load the ozone-site.xml from the
> classpath. But it makes very hard to start Ozone components in IDE as we
> can't modify the classpath easily.
> One option here is to support the --conf everywhere to make it possible to
> start ozone cluster in the IDE.
> Note: It's a nice to have for 0.4.0. I marked it as 0.5.0 but safe to commit
> at anytime to 0.4.0
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
