[ 
https://issues.apache.org/jira/browse/HDFS-14427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818285#comment-16818285
 ] 

Íñigo Goiri commented on HDFS-14427:
------------------------------------

Thanks [~fengnanli] for bringing this up.
I would leave the behavior as is and update the comment.
I also think it'd be nice to have the extra option to specify the number of 
Routers; we can use -1 to leave as it is right now.

> RBF: Optimize some testing set up logic in MiniRouterDFSCluster
> ---------------------------------------------------------------
>
>                 Key: HDFS-14427
>                 URL: https://issues.apache.org/jira/browse/HDFS-14427
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Fengnan Li
>            Assignee: Fengnan Li
>            Priority: Major
>
> [https://github.com/apache/hadoop/blob/HDFS-13891/hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/MiniRouterDFSCluster.java#L808]
> the comment says one router is created per name service, while in the code 
> one router is created per namenode in each nameservice.
> There are a couple of things that might need to consider optimization:
>  # make the code as the the comment
>  # add some ways to specify the number of routers



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to