[
https://issues.apache.org/jira/browse/HDFS-14427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820338#comment-16820338
]
Fengnan Li edited comment on HDFS-14427 at 4/17/19 5:41 PM:
------------------------------------------------------------
[~elgoiri] Thanks for the comment.
I also like the idea that having an extra option to specify the number of
Routers, so if we keep the current logic of # of Routers = # of Namenodes, we
will need to give out functions with signatures like either specifying the
number of Routers or number of Namenodes but not both since that will mislead
people to specify mismatched count.
Will upload a patch later for this
was (Author: fengnanli):
[~elgoiri] Thanks for the comment.
I also like the idea that having an extra option to specify the number of
Routers, so if we keep the current logic of # of Routers = # of Namenodes, we
will need to give out functions with signatures like either specifying the
number of Routers or number of Namenodes but not both since that will mislead
people to specify mismatched count.
> RBF: Optimize some testing set up logic in MiniRouterDFSCluster
> ---------------------------------------------------------------
>
> Key: HDFS-14427
> URL: https://issues.apache.org/jira/browse/HDFS-14427
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Fengnan Li
> Assignee: Fengnan Li
> Priority: Major
>
> [https://github.com/apache/hadoop/blob/HDFS-13891/hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/MiniRouterDFSCluster.java#L808]
> the comment says one router is created per name service, while in the code
> one router is created per namenode in each nameservice.
> There are a couple of things that might need to consider optimization:
> # make the code as the the comment
> # add some ways to specify the number of routers
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
