[
https://issues.apache.org/jira/browse/HDFS-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820646#comment-16820646
]
Yiqun Lin commented on HDFS-14406:
----------------------------------
Almost looks great now, [~xuel1].
{quote}RpcUserMetrics and RpcDetailedMetrics are nearly identical, can we have
a common base class which they both inherit from, or even just let
RpcUserMetrics extends RpcDetailedMetrics? The only differences are the init
step, and the name which is passed to the registry.
{quote}
As I reviewed the latest patch, I suppose this comment was not addressed. And
not so sure why we introduced new name (method name + username) as the metric
name rather than username only. This will lead a per user per rpc metric.
{code:java}
+ public void addProcessingTime(String methodName, String username,
+ int processingTime) {
+ String prefix = String.format("%1s-%2s-", methodName, username);
+ rates.add(prefix, processingTime);
+ }
{code}
> Add per user RPC Processing time
> --------------------------------
>
> Key: HDFS-14406
> URL: https://issues.apache.org/jira/browse/HDFS-14406
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 3.2.0
> Reporter: Xue Liu
> Assignee: Xue Liu
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: HDFS-14406.001.patch, HDFS-14406.002.patch,
> HDFS-14406.003.patch, HDFS-14406.004.patch, HDFS-14406.005.patch
>
>
> For a shared cluster we would want to separate users' resources, as well as
> having our metrics reflecting on the usage, latency, etc, for each user.
> This JIRA aims to add per user RPC processing time metrics and expose it via
> JMX.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
