[ https://issues.apache.org/jira/browse/HDDS-1411?focusedWorklogId=230234&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230234 ]
ASF GitHub Bot logged work on HDDS-1411: ---------------------------------------- Author: ASF GitHub Bot Created on: 19/Apr/19 18:47 Start Date: 19/Apr/19 18:47 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #755: HDDS-1411. Add unit test to check if SCM correctly sends close commands for containers in closing state after a restart. URL: https://github.com/apache/hadoop/pull/755#issuecomment-484984070 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 22 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 351 | Maven dependency ordering for branch | | +1 | mvninstall | 1219 | trunk passed | | +1 | compile | 970 | trunk passed | | +1 | checkstyle | 144 | trunk passed | | +1 | mvnsite | 178 | trunk passed | | +1 | shadedclient | 1107 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 50 | trunk passed | | +1 | javadoc | 59 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 20 | Maven dependency ordering for patch | | +1 | mvninstall | 67 | the patch passed | | +1 | compile | 894 | the patch passed | | +1 | javac | 894 | the patch passed | | +1 | checkstyle | 140 | the patch passed | | +1 | mvnsite | 77 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 718 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 56 | the patch passed | | +1 | javadoc | 52 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 109 | server-scm in the patch failed. | | -1 | unit | 1275 | integration-test in the patch failed. | | +1 | asflicense | 69 | The patch does not generate ASF License warnings. | | | | 7520 | | | Reason | Tests | |-------:|:------| | Failed junit tests | hadoop.ozone.TestOzoneConfigurationFields | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-755/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/755 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux f54447a63363 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / aeadb94 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-755/2/artifact/out/patch-unit-hadoop-hdds_server-scm.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-755/2/artifact/out/patch-unit-hadoop-ozone_integration-test.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-755/2/testReport/ | | Max. process+thread count | 5159 (vs. ulimit of 5500) | | modules | C: hadoop-hdds/server-scm hadoop-ozone/integration-test U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-755/2/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 230234) Time Spent: 0.5h (was: 20m) > Add unit test to check if SCM correctly sends close commands for containers > in closing state after a restart > ------------------------------------------------------------------------------------------------------------ > > Key: HDDS-1411 > URL: https://issues.apache.org/jira/browse/HDDS-1411 > Project: Hadoop Distributed Data Store > Issue Type: Test > Components: test > Reporter: Nanda kumar > Assignee: Siddharth Wagle > Priority: Major > Labels: newbie, pull-request-available > Attachments: HDDS-1411.01.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > When the container is in CLOSING state, SCM keeps sending close command to > the datanode until the container is either moved to QUASI_CLOSED or CLOSED > state. The frequency in which the close command is sent by SCM depends on the > property {{hdds.scm.replication.thread.interval}}. > We have to add a test case to verify whether SCM is sending close commands > for containers in the closing state even after a restart. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org