[
https://issues.apache.org/jira/browse/HDDS-1453?focusedWorklogId=231500&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-231500
]
ASF GitHub Bot logged work on HDDS-1453:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Apr/19 16:30
Start Date: 23/Apr/19 16:30
Worklog Time Spent: 10m
Work Description: anuengineer commented on pull request #759: HDDS-1453.
Fix unit test TestConfigurationFields broken on trunk. (swagle)
URL: https://github.com/apache/hadoop/pull/759#discussion_r277766213
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2286,12 +2286,20 @@
ozone.metadata.dirs.
</description>
</property>
+ <property>
+ <name>ozone.scm.network.topology.schema.file.type</name>
+ <value>xml</value>
+ <tag>OZONE, MANAGEMENT</tag>
Review comment:
I think we should add a new tag called network since Management sounds too
wide and catch all. Or if you want to be more specific, Topology might be good
too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 231500)
Time Spent: 50m (was: 40m)
> Fix unit test TestConfigurationFields broken on trunk
> -----------------------------------------------------
>
> Key: HDDS-1453
> URL: https://issues.apache.org/jira/browse/HDDS-1453
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Affects Versions: 0.5.0
> Reporter: Siddharth Wagle
> Assignee: Siddharth Wagle
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Unit test failure::
> {code}
> [INFO] Running org.apache.hadoop.ozone.TestOzoneConfigurationFields
> [ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.772
> s <<< FAILURE! - in org.apache.hadoop.ozone.TestOzoneConfigurationFields
> [ERROR]
> testCompareConfigurationClassAgainstXml(org.apache.hadoop.ozone.TestOzoneConfigurationFields)
> Time elapsed: 0.052 s <<< FAILURE!
> java.lang.AssertionError: class org.apache.hadoop.ozone.OzoneConfigKeys class
> org.apache.hadoop.hdds.scm.ScmConfigKeys class
> org.apache.hadoop.ozone.om.OMConfigKeys class
> org.apache.hadoop.hdds.HddsConfigKeys class
> org.apache.hadoop.ozone.recon.ReconServerConfigKeys class
> org.apache.hadoop.ozone.s3.S3GatewayConfigKeys has 1 variables missing in
> ozone-default.xml Entries: ozone.scm.network.topology.schema.file.type
> expected:<0> but was:<1>
> at org.junit.Assert.fail(Assert.java:88)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
