[
https://issues.apache.org/jira/browse/HDFS-14453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824454#comment-16824454
]
Shweta edited comment on HDFS-14453 at 4/23/19 7:28 PM:
--------------------------------------------------------
Thank you [~belugabehr] for reporting this. Posted patch v001 per your
suggestion. Please review.
In DataStreamer class, the LOG.Debug statements use parameterized logging but
the LOG.WARN and LOG.INFO statements do not. Do you think I should use
parameterized logging for these too and extend the scope for this JIRA?
was (Author: shwetayakkali):
Thank you [~belugabehr] for reporting this. Posted patch v001 per your
suggestion.
In DataStreamer class, the LOG.Debug statements use parameterized logging but
the LOG.WARN and LOG.INFO statements do not. Do you think I should use
parameterized logging for these too and extend the scope for this JIRA?
> Improve Bad Sequence Number Error Message
> -----------------------------------------
>
> Key: HDFS-14453
> URL: https://issues.apache.org/jira/browse/HDFS-14453
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 3.2.0
> Reporter: David Mollitor
> Assignee: Shweta
> Priority: Minor
> Labels: noob
> Attachments: HDFS-14453.001.patch
>
>
> {code:java|title=DataStreamer.java}
> if (one.getSeqno() != seqno) {
> throw new IOException("ResponseProcessor: Expecting seqno" +
> " for block " + block +
> one.getSeqno() + " but received " + seqno);
> }
> {code}
> https://github.com/apache/hadoop/blob/685cb83e4c3f433c5147e35217ce79ea520a0da5/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java#L1154-L1158
> There is no space between the {{block}} and the {{one.getSeqno()}}. Please
> change to:
> {code:java}
> if (one.getSeqno() != seqno) {
> throw new IOException("ResponseProcessor: Expecting seqno " +
> one.getSeqno()
> + " for block " + block + " but received " + seqno);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
