[
https://issues.apache.org/jira/browse/HDDS-1455?focusedWorklogId=231699&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-231699
]
ASF GitHub Bot logged work on HDDS-1455:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Apr/19 20:51
Start Date: 23/Apr/19 20:51
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #762: HDDS-1455.
Inconsistent naming convention with Ozone Kerberos configu…
URL: https://github.com/apache/hadoop/pull/762#issuecomment-485969579
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 26 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 26 | Maven dependency ordering for branch |
| +1 | mvninstall | 1028 | trunk passed |
| +1 | compile | 1067 | trunk passed |
| +1 | checkstyle | 137 | trunk passed |
| +1 | mvnsite | 164 | trunk passed |
| +1 | shadedclient | 669 | branch has no errors when building and testing
our client artifacts. |
| 0 | findbugs | 0 | Skipped patched modules with no Java source:
hadoop-hdds/docs hadoop-ozone/dist |
| +1 | findbugs | 83 | trunk passed |
| +1 | javadoc | 105 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 26 | Maven dependency ordering for patch |
| -1 | mvninstall | 19 | dist in the patch failed. |
| +1 | compile | 1083 | the patch passed |
| +1 | javac | 1083 | the patch passed |
| +1 | checkstyle | 143 | the patch passed |
| +1 | mvnsite | 123 | the patch passed |
| +1 | shellcheck | 0 | There were no new shellcheck issues. |
| +1 | shelldocs | 31 | There were no new shelldocs issues. |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | xml | 1 | The patch has no ill-formed XML file. |
| +1 | shadedclient | 668 | patch has no errors when building and testing
our client artifacts. |
| 0 | findbugs | 0 | Skipped patched modules with no Java source:
hadoop-hdds/docs hadoop-ozone/dist |
| +1 | findbugs | 91 | the patch passed |
| +1 | javadoc | 108 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 94 | common in the patch failed. |
| +1 | unit | 32 | docs in the patch passed. |
| +1 | unit | 34 | dist in the patch passed. |
| +1 | asflicense | 43 | The patch does not generate ASF License warnings. |
| | | 6160 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdds.scm.net.TestNodeSchemaManager |
| | hadoop.hdds.scm.net.TestNetworkTopologyImpl |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-762/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/762 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle xml shellcheck shelldocs
|
| uname | Linux a10b4104e3e5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 59ded76 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| shellcheck | v0.4.6 |
| findbugs | v3.1.0-RC1 |
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-762/1/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-762/1/artifact/out/patch-unit-hadoop-hdds_common.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-762/1/testReport/ |
| Max. process+thread count | 446 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common hadoop-hdds/docs hadoop-ozone/dist U: . |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-762/1/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 231699)
Time Spent: 0.5h (was: 20m)
> Inconsistent naming convention with Ozone Kerberos configuration
> ----------------------------------------------------------------
>
> Key: HDDS-1455
> URL: https://issues.apache.org/jira/browse/HDDS-1455
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Eric Yang
> Assignee: Xiaoyu Yao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In SetupSecureOzone.md, the naming convention for keytab files are different
> from code.
> {code}
> hdds.scm.http.kerberos.keytab
> ozone.om.http.kerberos.keytab
> {code}
> In ozone-default.xml, it is looking for:
> {code}
> hdds.scm.http.kerberos.keytab
> ozone.om.http.kerberos.keytab.file
> {code}
> For the non http version of keytab, they are branded as:
> {code}
> hdds.scm.kerberos.keytab.file
> ozone.om.kerberos.keytab.file
> {code}
> It is best to shorten the name to remove .file suffix from the code to be
> consistent with Hadoop naming convention. The second nitpick is hdds and
> ozone prefix. Is there a good reason to have distinct prefix for both that
> work closely together? How about hadoop.ozone prefix? From usability point
> of view, the current prefix are very confusing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
