[
https://issues.apache.org/jira/browse/HDDS-1424?focusedWorklogId=232648&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-232648
]
ASF GitHub Bot logged work on HDDS-1424:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/19 08:43
Start Date: 25/Apr/19 08:43
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #726: HDDS-1424.
Support multi-container robot test execution
URL: https://github.com/apache/hadoop/pull/726#issuecomment-486576162
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 24 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 1254 | trunk passed |
| +1 | compile | 129 | trunk passed |
| +1 | mvnsite | 35 | trunk passed |
| +1 | shadedclient | 654 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 26 | trunk passed |
||| _ Patch Compile Tests _ |
| -1 | mvninstall | 24 | dist in the patch failed. |
| +1 | compile | 22 | the patch passed |
| +1 | javac | 22 | the patch passed |
| +1 | mvnsite | 23 | the patch passed |
| -1 | shellcheck | 2 | The patch generated 2 new + 0 unchanged - 1 fixed =
2 total (was 1) |
| +1 | shelldocs | 22 | The patch generated 0 new + 104 unchanged - 132
fixed = 104 total (was 236) |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | xml | 1 | The patch has no ill-formed XML file. |
| +1 | shadedclient | 743 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 16 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 19 | dist in the patch passed. |
| +1 | asflicense | 30 | The patch does not generate ASF License warnings. |
| | | 3139 | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-726/5/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/726 |
| Optional Tests | dupname asflicense shellcheck shelldocs compile
javac javadoc mvninstall mvnsite unit shadedclient xml |
| uname | Linux 8006a03f0cac 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 0b3d41b |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| shellcheck | v0.4.6 |
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-726/5/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
|
| shellcheck |
https://builds.apache.org/job/hadoop-multibranch/job/PR-726/5/artifact/out/diff-patch-shellcheck.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-726/5/testReport/ |
| Max. process+thread count | 446 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/dist U: hadoop-ozone/dist |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-726/5/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 232648)
Time Spent: 1.5h (was: 1h 20m)
> Support multi-container robot test execution
> --------------------------------------------
>
> Key: HDDS-1424
> URL: https://issues.apache.org/jira/browse/HDDS-1424
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The ./smoketest folder in the distribution package contains robotframework
> based test scripts to test the main behaviour of Ozone.
> The tests have two layers:
> 1. robot test definitions to execute commands and assert the results (on a
> given host machine)
> 2. ./smoketest/test.sh which starts/stops the docker-compose based
> environments AND execute the selected robot tests inside the right hosts
> The second one (test.sh) has some serious limitations:
> 1. all the tests are executed inside the same container (om):
> https://github.com/apache/hadoop/blob/5f951ea2e39ae4dfe554942baeec05849cd7d3c2/hadoop-ozone/dist/src/main/smoketest/test.sh#L89
> Some of the tests (ozonesecure-mr, ozonefs) may require the flexibility to
> execute different robot tests in different containers.
> 2. The definition of the global test set is complex and hard to understood.
> The current code is:
> {code}
> TESTS=("basic")
> execute_tests ozone "${TESTS[@]}"
> TESTS=("auditparser")
> execute_tests ozone "${TESTS[@]}"
> TESTS=("ozonefs")
> execute_tests ozonefs "${TESTS[@]}"
> TESTS=("basic")
> execute_tests ozone-hdfs "${TESTS[@]}"
> TESTS=("s3")
> execute_tests ozones3 "${TESTS[@]}"
> TESTS=("security")
> execute_tests ozonesecure .
> {code}
> For example for ozonesecure the TESTS is not used. And the usage of bash
> lists require additional complexity in the execute_tests function.
> I propose here a very lightweight refactor. Instead of including both the
> test definitions AND the helper methods in test.sh I would separate them.
> Let's put a test.sh to each of the compose directories. The separated test.sh
> can include common methods from a main shell script. For example:
> {code}
> source "$COMPOSE_DIR/../testlib.sh"
> start_docker_env
> execute_robot_test scm basic/basic.robot
> execute_robot_test scm s3
> stop_docker_env
> generate_report
> {code}
> This is a more clean and more flexible definition. It's easy to execute just
> this test (as it's saved to the compose/ozones3 directory. And it's more
> flexible.
> Other example, where multiple containers are used to execute tests:
> {code}
> source "$COMPOSE_DIR/../testlib.sh"
> start_docker_env
> execute_robot_test scm ozonefs/ozonefs.robot
> export OZONE_HOME=/opt/ozone
> execute_robot_test hadoop32 ozonefs/hadoopo3fs.robot
> execute_robot_test hadoop31 ozonefs/hadoopo3fs.robot
> stop_docker_env
> generate_report
> {code}
> With this separation the definition of the helper methods (eg.
> execute_robot_test or stop_docker_env) would also be simplified.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
