[
https://issues.apache.org/jira/browse/HDFS-14356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825899#comment-16825899
]
Feilong He commented on HDFS-14356:
-----------------------------------
[~Sammi], I am so appreciative of your review. Your suggestions are quite
valuable to us.
{quote}Use constants or enum for pmdk status
{quote}
Good suggestion. As you suggested, it's quite reasonable to use enum to keep
pmdk support state codes. I will refine this part of impl in the new patch.
{quote}Is there potential buffer overflow risk here?
{quote}
Actually, snprintf() method will truncate excessive characters when putting
pmem error message into msg[1000]. So there should be no buffer overflow risk
here. I will check other pieces of code to avoid this issue. Thanks for your
great insight.
{quote}Do you plan to support Windows in this patch? If not, please clarify
the supported platform in the title or in the description. Also make sure when
compile native is enabled(-Pnative), following two cases pass
{quote} *
{quote} Linux platform, compile with and without PMDK enabled{quote}
*
{quote} Windows platform, compile without PMDK enabled{quote}
I will make sure the two build cases pass. For linux platform, the build can
pass on my side regardless of whether PMDK is enabled. And I will prepare a
windows environment to make sure that.
Thanks [~Sammi] again!
> Implement HDFS cache on SCM with native PMDK libs
> -------------------------------------------------
>
> Key: HDFS-14356
> URL: https://issues.apache.org/jira/browse/HDFS-14356
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: caching, datanode
> Reporter: Feilong He
> Assignee: Feilong He
> Priority: Major
> Attachments: HDFS-14356.000.patch, HDFS-14356.001.patch
>
>
> In this implementation, native PMDK libs are used to map HDFS blocks to SCM.
> To use this implementation, user should build hadoop with PMDK libs by
> specifying a build option. This implementation is only supported in linux
> platform.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
