[
https://issues.apache.org/jira/browse/HDDS-1468?focusedWorklogId=232719&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-232719
]
ASF GitHub Bot logged work on HDDS-1468:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/19 10:34
Start Date: 25/Apr/19 10:34
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #772: HDDS-1468. Inject
configuration values to Java objects
URL: https://github.com/apache/hadoop/pull/772#issuecomment-486619157
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 23 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 4 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 40 | Maven dependency ordering for branch |
| +1 | mvninstall | 1207 | trunk passed |
| +1 | compile | 74 | trunk passed |
| +1 | checkstyle | 31 | trunk passed |
| +1 | mvnsite | 76 | trunk passed |
| +1 | shadedclient | 833 | branch has no errors when building and testing
our client artifacts. |
| +1 | findbugs | 113 | trunk passed |
| +1 | javadoc | 58 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 11 | Maven dependency ordering for patch |
| +1 | mvninstall | 74 | the patch passed |
| +1 | compile | 70 | the patch passed |
| +1 | javac | 70 | the patch passed |
| -0 | checkstyle | 25 | hadoop-hdds: The patch generated 1 new + 0
unchanged - 0 fixed = 1 total (was 0) |
| +1 | mvnsite | 61 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 804 | patch has no errors when building and testing
our client artifacts. |
| +1 | findbugs | 119 | the patch passed |
| +1 | javadoc | 54 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 78 | common in the patch passed. |
| -1 | unit | 88 | server-scm in the patch failed. |
| +1 | asflicense | 27 | The patch does not generate ASF License warnings. |
| | | 3896 | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/772 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 8e6273679b38 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed
Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 0b3d41b |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/1/artifact/out/diff-checkstyle-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/1/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/1/testReport/ |
| Max. process+thread count | 464 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-772/1/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 232719)
Time Spent: 20m (was: 10m)
> Inject configuration values to Java objects
> -------------------------------------------
>
> Key: HDDS-1468
> URL: https://issues.apache.org/jira/browse/HDDS-1468
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> According to the design doc in the parent issue we would like to support java
> configuration objects which are simple POJO but the fields/setters are
> annotated. As a first step we can introduce the
> OzoneConfiguration.getConfigObject() api which can create the config object
> and inject configuration.
> Later we can improve it with annotation processor which can generate the
> ozone-default.xml.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
