[
https://issues.apache.org/jira/browse/HDDS-1469?focusedWorklogId=233073&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-233073
]
ASF GitHub Bot logged work on HDDS-1469:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/19 19:39
Start Date: 25/Apr/19 19:39
Worklog Time Spent: 10m
Work Description: anuengineer commented on issue #773: HDDS-1469.
Generate default configuration fragments based on annotations
URL: https://github.com/apache/hadoop/pull/773#issuecomment-486810661
> /cc @anuengineer This is the annotation processor. With a small
modification in the OzoneConfiguration (to load all the generated fragments) we
don't need to merge all the generated config files to one big ozone-default.xml
I am ok with that, but some of the old school people might like a single
file, and in the deployment, phase don't we need a single file ? or should we
move away since the code already has the default?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 233073)
Time Spent: 2h 20m (was: 2h 10m)
> Generate default configuration fragments based on annotations
> -------------------------------------------------------------
>
> Key: HDDS-1469
> URL: https://issues.apache.org/jira/browse/HDDS-1469
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> See the design doc in the parent jira for more details.
> In this jira I introduce a new annotation processor which can generate
> ozone-default.xml fragments based on the annotations which are introduced by
> HDDS-1468.
> The ozone-default-generated.xml fragments can be used directly by the
> OzoneConfiguration as I added a small code to the constructor to check ALL
> the available ozone-default-generated.xml files and add them to the available
> resources.
> With this approach we don't need to edit ozone-default.xml as all the
> configuration can be defined in java code.
> As a side effect each service will see only the available configuration keys
> and values based on the classpath. (If the ozone-default-generated.xml file
> of OzoneManager is not on the classpath of the SCM, SCM doesn't see the
> available configs.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
