[
https://issues.apache.org/jira/browse/HDDS-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830307#comment-16830307
]
Elek, Marton commented on HDDS-1458:
------------------------------------
Thank you very much to work on this [~eyang]. It looks very promising.
Here is my personal opinion:
bq. Are we ok with docker in docker addition to start-build-env.sh because it
uses --privileged command to gain access to host level docker. In my opinion,
the existing setup already require user to have access to docker. This new
privileged flag gives more power to break out of container environment, but it
is necessary to simulate network or disk failures. I am fine without bundle
this in start-build-env.sh, but it is nicer without having to look for
developer dependencies to start development.
As of now we use '--privileged' on jenkins builds, so the usage of privileged
shouldn't be a problem. It's an other question to include it as a default
option in ./start-build.env.sh. That script is not used on jenkins and I have
no strong preferences.
As most of the user run build without any container isolation (just in the
local machine) I don't think it's a strong limitation to make the docker run to
privileged.
bq. Can we move hadoop-ozone/dist/src/main/blockade into integration-test
project? It seems a more logical choice to host fault injection test suites.
I have no strong preferences, I can live with both the options. Personally I
would prefer to keep it separated. For me the junit test based integration
tests and the blockade tests are different things. But it may be useful to move
out blockade tests from dist to a separated project if you prefer it.
bq. Do we want the test to run as a profile, or default "mvn verify" is good?
I would use a dedicated profile. The standard mvn verify (or mvn install) is
expected to be used by new contributors. I would keep that one as simple as
possible.
> Create a maven profile to run fault injection tests
> ---------------------------------------------------
>
> Key: HDDS-1458
> URL: https://issues.apache.org/jira/browse/HDDS-1458
> Project: Hadoop Distributed Data Store
> Issue Type: Test
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Major
> Attachments: HDDS-1458.001.patch
>
>
> Some fault injection tests have been written using blockade. It would be
> nice to have ability to start docker compose and exercise the blockade test
> cases against Ozone docker containers, and generate reports. This is
> optional integration tests to catch race conditions and fault tolerance
> defects.
> We can introduce a profile with id: it (short for integration tests). This
> will launch docker compose via maven-exec-plugin and run blockade to simulate
> container failures and timeout.
> Usage command:
> {code}
> mvn clean verify -Pit
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
