[
https://issues.apache.org/jira/browse/HDDS-1224?focusedWorklogId=236415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-236415
]
ASF GitHub Bot logged work on HDDS-1224:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/May/19 16:58
Start Date: 02/May/19 16:58
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #793: HDDS-1224.
Restructure code to validate the response from server in the Read path.
URL: https://github.com/apache/hadoop/pull/793#issuecomment-488750605
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 44 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 5 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 23 | Maven dependency ordering for branch |
| +1 | mvninstall | 409 | trunk passed |
| +1 | compile | 211 | trunk passed |
| +1 | checkstyle | 54 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 876 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 137 | trunk passed |
| 0 | spotbugs | 282 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 477 | trunk passed |
| -0 | patch | 308 | Used diff version of patch file. Binary files and
potentially other changes not applied. Please rebase and squash commits if
necessary. |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 25 | Maven dependency ordering for patch |
| +1 | mvninstall | 422 | the patch passed |
| +1 | compile | 203 | the patch passed |
| +1 | javac | 203 | the patch passed |
| -0 | checkstyle | 29 | hadoop-hdds: The patch generated 41 new + 0
unchanged - 0 fixed = 41 total (was 0) |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | xml | 1 | The patch has no ill-formed XML file. |
| +1 | shadedclient | 717 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 140 | the patch passed |
| -1 | findbugs | 249 | hadoop-hdds generated 1 new + 0 unchanged - 0 fixed
= 1 total (was 0) |
| -1 | findbugs | 208 | hadoop-ozone in the patch failed. |
||| _ Other Tests _ |
| -1 | unit | 159 | hadoop-hdds in the patch failed. |
| -1 | unit | 50 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 28 | The patch does not generate ASF License warnings. |
| | | 4612 | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-hdds |
| | Inconsistent synchronization of
org.apache.hadoop.hdds.scm.storage.BlockInputStream.chunkIndex; locked 96% of
time Unsynchronized access at BlockInputStream.java:96% of time
Unsynchronized access at BlockInputStream.java:[line 303] |
| Failed junit tests |
hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerCommandHandler
|
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-793/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/793 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle xml |
| uname | Linux 9943a2f5c261 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon
Mar 18 15:02:05 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 6a42745 |
| Default Java | 1.8.0_191 |
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-793/1/artifact/out/diff-checkstyle-hadoop-hdds.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-793/1/artifact/out/new-findbugs-hadoop-hdds.html
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-793/1/artifact/out/patch-findbugs-hadoop-ozone.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-793/1/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-793/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-793/1/testReport/ |
| Max. process+thread count | 370 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/client
hadoop-ozone/integration-test U: . |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-793/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 236415)
Time Spent: 20m (was: 10m)
> Restructure code to validate the response from server in the Read path
> ----------------------------------------------------------------------
>
> Key: HDDS-1224
> URL: https://issues.apache.org/jira/browse/HDDS-1224
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Client
> Affects Versions: 0.4.0
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In the read path, the validation of the response while reading the data from
> the datanodes happen in XceiverClientGrpc as well as additional Checksum
> verification happens in Ozone client to verify the read chunk response. The
> aim of this Jira is to modify the function call to take a validator function
> as a part of reading data so all validation can happen in a single unified
> place.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
