[
https://issues.apache.org/jira/browse/HDFS-14451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832000#comment-16832000
]
Shweta edited comment on HDFS-14451 at 5/2/19 9:28 PM:
-------------------------------------------------------
Thanks for the review [~jojochuang].
Sure, I didn't previous add the {{setupBadVersionResponse(version);} for the
first case since it doesn't have any Header information sent in the response
but as you mentioned in our offline sync that one reason for a difference in
header length can also be due to Client and Server having different versions.
Added the call to {{setupBadVersionResponse(version);} in patch v002. Please
review. Thanks.
was (Author: shwetayakkali):
Thanks for the review [~jojochuang].
Sure, I didn't previous add the {{setupBadVersionResponse(version);} for the
first case since it doesn't have any Header information sent but as you
mentioned in our offline sync that one reason for a difference in header length
can also be due to Client and Server having different versions.
Added the call to {{setupBadVersionResponse(version);} in patch v002. Please
review. Thanks.
> Incorrect header or version mismatch log message
> ------------------------------------------------
>
> Key: HDFS-14451
> URL: https://issues.apache.org/jira/browse/HDFS-14451
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 3.2.0
> Reporter: David Mollitor
> Assignee: Shweta
> Priority: Minor
> Labels: noob
> Attachments: HDFS-14451.001.patch
>
>
> {code:java|title=Server.java}
> if (!RpcConstants.HEADER.equals(dataLengthBuffer)
> || version != CURRENT_VERSION) {
> //Warning is ok since this is not supposed to happen.
> LOG.warn("Incorrect header or version mismatch from " +
> hostAddress + ":" + remotePort +
> " got version " + version +
> " expected version " + CURRENT_VERSION);
> setupBadVersionResponse(version);
> return -1;
> {code}
> This message should include the value of {{RpcConstants.HEADER}} and
> {{dataLengthBuffer}} in addition to just the version information or else that
> data is lost.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
