[
https://issues.apache.org/jira/browse/HDFS-14195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834031#comment-16834031
]
Wei-Chiu Chuang commented on HDFS-14195:
----------------------------------------
Thanks [~suxingfate] for reporting the issue and submitting the patch.
I think the patch looks good overall. The only thing I am concerned is that the
patch adds a new field in the delimited output, and there are production tools
that parse the delimited oiv output. Additionally, in the future, it is likely
we will need to support more fields and more xattr types.
I would suggest to either add a command line option to turn this on only when
the option is specified, or update the doc stating the delimited output may
not be backward compatible, and provide the guideline for tools to adapt. For
example, perhaps the tool should instead look at the header to figure out which
column is the column for the data it looks for.
Thoughts?
> OIV: print out storage policy id in oiv Delimited output
> --------------------------------------------------------
>
> Key: HDFS-14195
> URL: https://issues.apache.org/jira/browse/HDFS-14195
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: tools
> Reporter: Wang, Xinglong
> Assignee: Wang, Xinglong
> Priority: Minor
> Attachments: HDFS-14195.001.patch, HDFS-14195.002.patch,
> HDFS-14195.003.patch, HDFS-14195.004.patch, HDFS-14195.005.patch,
> HDFS-14195.006.patch
>
>
> There is lacking of a method to get all folders and files with sort of
> specified storage policy via command line, like ALL_SSD type.
> By adding storage policy id to oiv output, it will help with oiv
> post-analysis to have a overview of all folders/files with specified storage
> policy and to apply internal regulation based on this information.
>
> Currently, for PBImageXmlWriter.java, in HDFS-9835 it added function to print
> out xattr which including storage policy already.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
