[ 
https://issues.apache.org/jira/browse/HDDS-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835380#comment-16835380
 ] 

Elek, Marton commented on HDDS-1458:
------------------------------------

Thanks the v004 patch [~eyang].

Some comments:

1. I like the separated projects of the different fault-injection tests.

2. However you removed the blockade test from the release package. Can you 
please keep this functionality (to execute tests from distribution tar) as of 
now? And we agreed to support the execution of the tests in both way, I would 
suggest to put all the new tests to the tar file as well. Maybe we can create a 
new subdirectory for all the tests in the tar.

I think it will simplify the build process as you don't need the maintain the 
dev -compose files as they are already added to the distribution under the 
compose folder (even better, we can execute the fault injection tests in any of 
the provided environments: secure/not-secure, etc.)-

3. The docker-compose file of "fault-injection-test/disk-tests/read-only-test" 
is not tested IMHO. The conf directory should be moved out to a rw area as the 
configuration are generated runtime based on the environment variables (I am 
fine to fix ii in a follow-up jira)

> Create a maven profile to run fault injection tests
> ---------------------------------------------------
>
>                 Key: HDDS-1458
>                 URL: https://issues.apache.org/jira/browse/HDDS-1458
>             Project: Hadoop Distributed Data Store
>          Issue Type: Test
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HDDS-1458.001.patch, HDDS-1458.002.patch, 
> HDDS-1458.003.patch, HDDS-1458.004.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Some fault injection tests have been written using blockade.  It would be 
> nice to have ability to start docker compose and exercise the blockade test 
> cases against Ozone docker containers, and generate reports.  This is 
> optional integration tests to catch race conditions and fault tolerance 
> defects. 
> We can introduce a profile with id: it (short for integration tests).  This 
> will launch docker compose via maven-exec-plugin and run blockade to simulate 
> container failures and timeout.
> Usage command:
> {code}
> mvn clean verify -Pit
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to