[
https://issues.apache.org/jira/browse/HDDS-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836863#comment-16836863
]
Xiaoyu Yao commented on HDDS-700:
---------------------------------
Thanks [~Sammi] for the patch. It LGTM overall. Here are a few comments:
DatanodeDetails.java
Line 266: can we update the toString to include the network location
information?
Line 353: if the caller does not set the location in the case of no topology
defined, should we have a default location like/default-location or
/default-rack.
SCMContainerPlacementRackAware.java
Line 77: should we consider redefine the interface to cover case where we want
include the affinity node in the first node selection as well? For example,
client inside the cluster may prefer to write first copy to local container if
possible.
Line 84: should we consider some fallback strategy in certain cases where we
allow allocation succeeds but
Recover later when the placement if possible later?
Line 88: NIT: can we rename it to chosenNodes?
Line 101-122: some of the logic can be consolidated.
Line 160: can we need to add some logic to avoid infinite loop in node
selection?
> Support rack awared node placement policy based on network topology
> -------------------------------------------------------------------
>
> Key: HDDS-700
> URL: https://issues.apache.org/jira/browse/HDDS-700
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Sammi Chen
> Priority: Major
> Attachments: HDDS-700.01.patch
>
>
> Implement a new container placement policy implementation based datanode's
> network topology. It follows the same rule as HDFS.
> By default with 3 replica, two replica will be on the same rack, the third
> replica and all the remaining replicas will be on different racks.
>
> {color:#808080} {color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
