[ 
https://issues.apache.org/jira/browse/HDFS-14447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839732#comment-16839732
 ] 

Íñigo Goiri commented on HDFS-14447:
------------------------------------

Thanks [~lukmajercak], I agree on fixing the spaces.
On top of that, a couple comments:
* It would be good to use StringBuilder in 
TestRefreshUserMappingsWithRouters#349.
* Use assertNotEquals in TestRefreshUserMappingsWithRouters#318
* In the waitFor you can use TimeUnit to convert between seconds and ms.
* In 331, use the logger and put some message. What about making it debug too?
* Fix style in TestRefreshUserMappingsWithRouters#209

[~shenyinjie] do you mind taking care of those?

> RBF: Router should support RefreshUserMappingsProtocol
> ------------------------------------------------------
>
>                 Key: HDFS-14447
>                 URL: https://issues.apache.org/jira/browse/HDFS-14447
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: rbf
>    Affects Versions: 3.1.0
>            Reporter: Shen Yinjie
>            Assignee: Shen Yinjie
>            Priority: Major
>             Fix For: HDFS-13891
>
>         Attachments: HDFS-14447-HDFS-13891.01.patch, 
> HDFS-14447-HDFS-13891.02.patch, HDFS-14447-HDFS-13891.03.patch, 
> HDFS-14447-HDFS-13891.04.patch, HDFS-14447-HDFS-13891.05.patch, 
> HDFS-14447-HDFS-13891.06.patch, error.png
>
>
> HDFS with RBF
> We configure hadoop.proxyuser.xx.yy ,then execute hdfs dfsadmin 
> -Dfs.defaultFS=hdfs://router-fed -refreshSuperUserGroupsConfiguration,
>  it throws "Unknown protocol: ...RefreshUserMappingProtocol".
> RouterAdminServer should support RefreshUserMappingsProtocol , or a proxyuser 
> client would be refused to impersonate.As shown in the screenshot



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to