[
https://issues.apache.org/jira/browse/HDDS-1509?focusedWorklogId=243316&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-243316
]
ASF GitHub Bot logged work on HDDS-1509:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/19 13:16
Start Date: 16/May/19 13:16
Worklog Time Spent: 10m
Work Description: mukul1987 commented on pull request #805: HDDS-1509.
TestBlockOutputStreamWithFailures#test2DatanodesFailure fails intermittently
URL: https://github.com/apache/hadoop/pull/805#discussion_r284697864
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyOutputStream.java
##########
@@ -259,15 +261,23 @@ private void handleException(BlockOutputStreamEntry
streamEntry,
if (!retryFailure) {
closedContainerException = checkIfContainerIsClosed(t);
}
- PipelineID pipelineId = null;
+ Pipeline pipeline = streamEntry.getPipeline();
+ PipelineID pipelineId = streamEntry.getPipeline().getId();
long totalSuccessfulFlushedData = streamEntry.getTotalAckDataLength();
//set the correct length for the current stream
streamEntry.setCurrentPosition(totalSuccessfulFlushedData);
long bufferedDataLen = blockOutputStreamEntryPool.computeBufferData();
- LOG.debug(
- "Encountered exception {}. The last committed block length is {}, "
- + "uncommitted data length is {} retry count {}", exception,
- totalSuccessfulFlushedData, bufferedDataLen, retryCount);
+ if (closedContainerException) {
+ LOG.debug(
+ "Encountered exception {}. The last committed block length is {}, "
+ + "uncommitted data length is {} retry count {}", exception,
+ totalSuccessfulFlushedData, bufferedDataLen, retryCount);
+ } else {
+ LOG.info(
Review comment:
lets change this to WARN
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 243316)
Time Spent: 20m (was: 10m)
> TestBlockOutputStreamWithFailures#test2DatanodesFailure fails intermittently
> ----------------------------------------------------------------------------
>
> Key: HDDS-1509
> URL: https://issues.apache.org/jira/browse/HDDS-1509
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Client
> Affects Versions: 0.5.0
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The test fails because, the test expects a exception after 2 datanodes
> failures to be of type RaftRetryFailureException. But it might happen that,
> the pipeline gets destroyed quickly then actual write executes over Ratis,
> hence it will fail with GroupMismatchhException in such case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
