[
https://issues.apache.org/jira/browse/HDDS-1550?focusedWorklogId=244082&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-244082
]
ASF GitHub Bot logged work on HDDS-1550:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/19 14:43
Start Date: 17/May/19 14:43
Worklog Time Spent: 10m
Work Description: jiwq commented on pull request #829: HDDS-1550.
MiniOzoneCluster is not shutting down all the threads during shutdown.
Contributed by Mukul Kumar Singh.
URL: https://github.com/apache/hadoop/pull/829#discussion_r285148899
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/report/ReportManager.java
##########
@@ -71,6 +76,11 @@ public void init() {
*/
public void shutdown() {
executorService.shutdown();
+ try {
+ executorService.awaitTermination(1, TimeUnit.DAYS);
+ } catch (Exception e) {
+ LOG.error("failed to shutdown Report Manager", e);
Review comment:
The first letter of the first word as a capital letter maybe better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 244082)
Time Spent: 50m (was: 40m)
> MiniOzoneCluster is not shutting down all the threads during shutdown.
> ----------------------------------------------------------------------
>
> Key: HDDS-1550
> URL: https://issues.apache.org/jira/browse/HDDS-1550
> Project: Hadoop Distributed Data Store
> Issue Type: Test
> Components: test
> Affects Versions: 0.3.0
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> MiniOzoneCluster does not shutdown all the threads during shutdown. All the
> threads must be shutdown to close the cluster correctly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
