[
https://issues.apache.org/jira/browse/HDDS-1499?focusedWorklogId=244381&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-244381
]
ASF GitHub Bot logged work on HDDS-1499:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/19 22:18
Start Date: 17/May/19 22:18
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #798:
HDDS-1499. OzoneManager Cache.
URL: https://github.com/apache/hadoop/pull/798#discussion_r285305076
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/TypedTable.java
##########
@@ -106,6 +142,40 @@ public void close() throws Exception {
}
+ @Override
+ public void addCacheEntry(CacheKey<KEY> cacheKey,
+ CacheValue<VALUE> cacheValue) {
+ // This will override the entry if there is already entry for this key.
+ cache.put(cacheKey, cacheValue);
+ }
+
+
+ @Override
+ public void cleanupCache(long epoch) {
Review comment:
This is added because, in actual usage of classes, we get Table reference,
and they can simply call table.cleanupCache(). Added getCache() only for
testing, so declared it as not a public method and annotated with
VisibleForTesting. This will be used after double-buffer integration completed.
Let me know if you still want to be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 244381)
Time Spent: 10h 10m (was: 10h)
> OzoneManager Cache
> ------------------
>
> Key: HDDS-1499
> URL: https://issues.apache.org/jira/browse/HDDS-1499
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10h 10m
> Remaining Estimate: 0h
>
> In this Jira, we shall implement a cache for Table.
> As with OM HA, we are planning to implement double buffer implementation to
> flush transaction in a batch, instead of using rocksdb put() for every
> operation. When this comes in to place we need cache in OzoneManager HA to
> handle/server the requests for validation/returning responses.
>
> This Jira will implement Cache as an integral part of the table. In this way
> users using this table does not need to handle like check cache/db. For this,
> we can update get API in the table to handle the cache.
>
> This Jira will implement:
> # Cache as a part of each Table.
> # Uses this cache in get().
> # Exposes api for cleanup, add entries to cache.
> Usage to add the entries in to cache will be done in further jira's.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
