[ 
https://issues.apache.org/jira/browse/HDDS-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844651#comment-16844651
 ] 

Supratim Deka commented on HDDS-1534:
-------------------------------------

Thanks [~nilotpalnandi] for the patch.

Why not change the type of the private member "exception" to Exception, instead 
of adding the new member failureCause?
This way we do not have to remember setting 2 values whenever there is an error.

Also a question about the validator, may be outside the scope of this Jira. 
Validator errors are just logged, but there is no indication of failure to the 
main flow. Does this behavior also need to be fixed? 

> freon should return non-zero exit code on failure
> -------------------------------------------------
>
>                 Key: HDDS-1534
>                 URL: https://issues.apache.org/jira/browse/HDDS-1534
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Nilotpal Nandi
>            Assignee: Nilotpal Nandi
>            Priority: Major
>         Attachments: HDDS-1534.001.patch
>
>
> Currently freon does not return any non-zero exit code even on failure.
> The status shows as "Failed" but the exit code is always zero.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to