[
https://issues.apache.org/jira/browse/HDDS-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845291#comment-16845291
]
Elek, Marton commented on HDDS-1458:
------------------------------------
Thank you very much the update [~eyang]
As I see the blockade compose files are moved from compose/ozoneblockade to
tests/compose. I am fine with this change, but:
1. Can you please delete the original one from the compose/ozoneblockade dir of
the dirst tar.
2. Can you please remove the -dev compose file? It can be confusing and this is
required only during the maven builds (In the current form the
dist-layout-stitching lines are duplicated. Fix me If I am wrong but the
compose files are copied twice).
3. Please use path which is relative to the py file instead of getcwd:
{code}
os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
{code}
instead of
{code}
os.getcwd()
{code}
The later one depends from the current directory. The original one makes it
easy to run the tests from any directories.
4. tests prefix is missing from README.md L38
5. I didn't have time yet to understood ./start-build-env.sh changes. But it
may be better to do in a HADOOP jira to get more visibility. If I understood
well it's not directly required but it's a generic improvements to make it
possible to run the ozone tests in the build docker containers. What do you
think?
6. Can you please help me to understand why do we need to set OZONE_HOME in
hadoop-ozone/fault-injection-test/network-tests/pom.xml. The MAVEN_HOME seems
to be enough.
7. Not clear the expected relationship between the network-tests and dist. Can
we add a provided dependency between them to make it explicit?
> Create a maven profile to run fault injection tests
> ---------------------------------------------------
>
> Key: HDDS-1458
> URL: https://issues.apache.org/jira/browse/HDDS-1458
> Project: Hadoop Distributed Data Store
> Issue Type: Test
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.4.1
>
> Attachments: HDDS-1458.001.patch, HDDS-1458.002.patch,
> HDDS-1458.003.patch, HDDS-1458.004.patch, HDDS-1458.005.patch,
> HDDS-1458.006.patch, HDDS-1458.007.patch, HDDS-1458.008.patch,
> HDDS-1458.009.patch, HDDS-1458.010.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Some fault injection tests have been written using blockade. It would be
> nice to have ability to start docker compose and exercise the blockade test
> cases against Ozone docker containers, and generate reports. This is
> optional integration tests to catch race conditions and fault tolerance
> defects.
> We can introduce a profile with id: it (short for integration tests). This
> will launch docker compose via maven-exec-plugin and run blockade to simulate
> container failures and timeout.
> Usage command:
> {code}
> mvn clean verify -Pit
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
