[ 
https://issues.apache.org/jira/browse/HDDS-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847188#comment-16847188
 ] 

Sammi Chen edited comment on HDDS-700 at 5/24/19 2:27 AM:
----------------------------------------------------------

Thanks [~xyao] for helping review and commit the patch. 

{quote}DatanodeDetails.java 
Line 357: if the network topology has additional layers above RACK, should we 
consider a more generic default network location?{quote}
I thought the same. It would better to get the default network location from 
NetworkTopologyInstance. But that means NetworkTopologyInstance need to passed 
in as a parameter when instantiating a DatanodeDetails object.  Will think 
about how to refactor this part in follow JIRAs. 


was (Author: sammi):
bq. Thanks [~xyao] for helping review and commit the patch. 

{quote}DatanodeDetails.java 
Line 357: if the network topology has additional layers above RACK, should we 
consider a more generic default network location?{quote}
I thought the same. It would better to get the default network location from 
NetworkTopologyInstance. But that means NetworkTopologyInstance need to passed 
in as a parameter when instantiating a DatanodeDetails object.  Will think 
about how to refactor this part in follow JIRAs. 

> Support rack awared node placement policy based on network topology
> -------------------------------------------------------------------
>
>                 Key: HDDS-700
>                 URL: https://issues.apache.org/jira/browse/HDDS-700
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Xiaoyu Yao
>            Assignee: Sammi Chen
>            Priority: Major
>             Fix For: 0.4.1
>
>         Attachments: HDDS-700.01.patch, HDDS-700.02.patch, HDDS-700.03.patch
>
>
> Implement a new container placement policy implementation based datanode's 
> network topology.  It follows the same rule as HDFS.
> By default with 3 replica, two replica will be on the same rack, the third 
> replica and all the remaining replicas will be on different racks. 
>  
> {color:#808080} {color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to