[
https://issues.apache.org/jira/browse/HDDS-1584?focusedWorklogId=248682&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-248682
]
ASF GitHub Bot logged work on HDDS-1584:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/19 08:45
Start Date: 27/May/19 08:45
Worklog Time Spent: 10m
Work Description: mukul1987 commented on pull request #845: HDDS-1584.
Fix TestFailureHandlingByClient tests
URL: https://github.com/apache/hadoop/pull/845#discussion_r287223711
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestFailureHandlingByClient.java
##########
@@ -214,12 +213,17 @@ public void
testMultiBlockWritesWithIntermittentDnFailures()
// get the name of a valid container
Assert.assertTrue(key.getOutputStream() instanceof KeyOutputStream);
- KeyOutputStream groupOutputStream =
+ KeyOutputStream keyOutputStream =
(KeyOutputStream) key.getOutputStream();
- List<OmKeyLocationInfo> locationInfoList =
- groupOutputStream.getLocationInfoList();
- Assert.assertTrue(locationInfoList.size() == 6);
- long containerId = locationInfoList.get(1).getContainerID();
+ List<BlockOutputStreamEntry> streamEntryList =
+ keyOutputStream.getStreamEntries();
+
+ // Assert that 1 block will be preallocated
Review comment:
The comment says 1 block. however we are checking for 6 blocks in the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 248682)
Time Spent: 40m (was: 0.5h)
> Fix TestFailureHandlingByClient tests
> -------------------------------------
>
> Key: HDDS-1584
> URL: https://issues.apache.org/jira/browse/HDDS-1584
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Client
> Affects Versions: 0.4.1
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.4.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The test failures are caused bcoz the test relies on
> KeyoutputStream#getLocationList() to validate the no of preallocated blocks,
> but it has been changed recently to exclude the empty blocks. The fix is
> mostly to use KeyOutputStream#getStreamEntries() to get the no of
> preallocated blocks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
