[
https://issues.apache.org/jira/browse/HDDS-1600?focusedWorklogId=249087&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-249087
]
ASF GitHub Bot logged work on HDDS-1600:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/May/19 03:04
Start Date: 28/May/19 03:04
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #857: HDDS-1600. Add
userName and IPAddress as part of OMRequest.
URL: https://github.com/apache/hadoop/pull/857#issuecomment-496348219
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 37 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 1 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 16 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 65 | Maven dependency ordering for branch |
| +1 | mvninstall | 527 | trunk passed |
| +1 | compile | 266 | trunk passed |
| +1 | checkstyle | 78 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 932 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 149 | trunk passed |
| 0 | spotbugs | 325 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 531 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 31 | Maven dependency ordering for patch |
| +1 | mvninstall | 505 | the patch passed |
| +1 | compile | 286 | the patch passed |
| +1 | cc | 286 | the patch passed |
| +1 | javac | 286 | the patch passed |
| -0 | checkstyle | 42 | hadoop-hdds: The patch generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) |
| -0 | checkstyle | 38 | hadoop-ozone: The patch generated 3 new + 0
unchanged - 0 fixed = 3 total (was 0) |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | xml | 3 | The patch has no ill-formed XML file. |
| +1 | shadedclient | 717 | patch has no errors when building and testing
our client artifacts. |
| -1 | javadoc | 78 | hadoop-ozone generated 6 new + 5 unchanged - 0 fixed =
11 total (was 5) |
| +1 | findbugs | 535 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 167 | hadoop-hdds in the patch failed. |
| -1 | unit | 51 | hadoop-ozone in the patch failed. |
| -1 | asflicense | 44 | The patch generated 17 ASF License warnings. |
| | | 12976 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.ozone.om.exceptions.TestResultCodes |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-857/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/857 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml findbugs checkstyle cc |
| uname | Linux e214af0213dd 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed
Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / b70d1be |
| Default Java | 1.8.0_212 |
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-857/3/artifact/out/diff-checkstyle-hadoop-hdds.txt
|
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-857/3/artifact/out/diff-checkstyle-hadoop-ozone.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-857/3/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-857/3/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-857/3/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-857/3/testReport/ |
| asflicense |
https://builds.apache.org/job/hadoop-multibranch/job/PR-857/3/artifact/out/patch-asflicense-problems.txt
|
| Max. process+thread count | 356 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common hadoop-ozone/common
hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: . |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-857/3/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 249087)
Time Spent: 0.5h (was: 20m)
> Add userName and IPAddress as part of OMRequest.
> ------------------------------------------------
>
> Key: HDDS-1600
> URL: https://issues.apache.org/jira/browse/HDDS-1600
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In OM HA, the actual execution of request happens under GRPC context, so UGI
> object which we retrieve from ProtobufRpcEngine.Server.getRemoteUser(); will
> not be available.
> In similar manner ProtobufRpcEngine.Server.getRemoteIp().
>
> So, during preExecute(which happens under RPC context) extract userName and
> IPAddress and add it to the OMRequest, and then send the request to ratis
> server.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
