[
https://issues.apache.org/jira/browse/HDDS-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849397#comment-16849397
]
Elek, Marton commented on HDDS-1458:
------------------------------------
Thank you very much to explain it [~eyang]
1. os.getcwd is the third option in your if condition. I think all of your use
cases can be supported by OZONE_HOME or MAVEN_TEST.
bq. The patched code is written to support the most frequent scenarios rather
than making only one assumption that the script is always fixated to the
relative location of docker compose file in binary release tarball
I didn't say that os.getcwd should be *removed*. I asked to keep the more
generic solution (which was used until now) as the default third option.
Nothing more.
bq. Feel the conversation has not been fruitful with you insist on doing
everything the old way, which has been identified as none-salable approach
Yes, I agree that it's a too long conversation, and not th most effective one.
Fortunately we had the following consensus:
* Keep the current approach of running tests and current distribution practice
as is.
* Support an other method (which is proposed by you) as part of the maven
build. (approach 1: running the tests from the dist with hadoop-runner,
approach 2: running tests from the maven based on pre-built images)
* We also agreed that all of the tests should be supported in both ways.
I think it's a good consensus, let's modify the patch according to this. Can
you please keep the docker-compose files in the dist in the original form?
> Create a maven profile to run fault injection tests
> ---------------------------------------------------
>
> Key: HDDS-1458
> URL: https://issues.apache.org/jira/browse/HDDS-1458
> Project: Hadoop Distributed Data Store
> Issue Type: Test
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.4.1
>
> Attachments: HDDS-1458.001.patch, HDDS-1458.002.patch,
> HDDS-1458.003.patch, HDDS-1458.004.patch, HDDS-1458.005.patch,
> HDDS-1458.006.patch, HDDS-1458.007.patch, HDDS-1458.008.patch,
> HDDS-1458.009.patch, HDDS-1458.010.patch, HDDS-1458.011.patch,
> HDDS-1458.012.patch, HDDS-1458.013.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Some fault injection tests have been written using blockade. It would be
> nice to have ability to start docker compose and exercise the blockade test
> cases against Ozone docker containers, and generate reports. This is
> optional integration tests to catch race conditions and fault tolerance
> defects.
> We can introduce a profile with id: it (short for integration tests). This
> will launch docker compose via maven-exec-plugin and run blockade to simulate
> container failures and timeout.
> Usage command:
> {code}
> mvn clean verify -Pit
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
